k8s-triage-robot
commented
4 months ago The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle stale - Close this issue with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
tenstad
adrianmoisey
Basically the same as Minimum CPU recommendation for a pod, just an additional upper bound: https://github.com/kubernetes/autoscaler/blob/ed6ebbe8baacab2fe1befd468ffaa049c66b0d73/vertical-pod-autoscaler/pkg/recommender/logic/recommender.go#L29
Which component are you using?:
vertical-pod-autoscaler
Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
VPA currently suggests cpu too close to / above CPU on node, leading to pods not starting.
Describe the solution you'd like.:
Add
pod-recommendation-max-cpu-millicoresandpod-recommendation-max-memory-mbflags, and cap recommendation to provided values. Maybe no upper limit by default.Describe any alternative solutions you've considered.:
Using policies to enforce the upper bound: https://github.com/kubernetes/autoscaler/blob/ed6ebbe8baacab2fe1befd468ffaa049c66b0d73/vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go#L205
Using LimitRange to enforce the upper bound: https://kubernetes.io/docs/concepts/policy/limit-range/
Additional context.:
Would be nice to define upper-bound a central place (controller), and not in policies LimitRanges.