kubernetes / autoscaler

Autoscaling components for Kubernetes
Apache License 2.0
7.95k stars 3.94k forks source link

vpa: Follow Kubernetes logging guideline #6905

Open ialidzhikov opened 3 months ago

ialidzhikov commented 3 months ago

Which component are you using?:

vertical-pod-autoscaler

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:

Currently, the logging in the VPA components does not follow the best practices and guidelines which are followed in the K8s ecosystem. VPA, as a core K8s component, should follow sig-instrumentation's Logging guide.

For example, let's take https://github.com/kubernetes/autoscaler/blob/bd8153b59d9d0da84a9d4e9b6b34e08f89b03f26/vertical-pod-autoscaler/pkg/updater/logic/updater.go#L220. The issues with this log are:

Describe the solution you'd like.: Follow sig-instrumentation's Logging guide in the VPA's codebase.

Describe any alternative solutions you've considered.: N/A

Additional context.: N/A

Shubham82 commented 3 months ago

/area vertical-pod-autoscaler

Shubham82 commented 3 months ago

cc @voelzmo @kwiesmueller

voelzmo commented 2 months ago

/triage accepted

omerap12 commented 3 weeks ago

/assign