search

kubernetes / autoscaler

Autoscaling components for Kubernetes
Apache License 2.0
7.8k stars 3.87k forks source link

Increase booking time for ProvisioningRequest to 20 minutes #6936

Open yaroslava-serdiuk opened 1 week ago

yaroslava-serdiuk commented 1 week ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

As discussed with @towca : the default timeout for a VM coming up after a scale-up request is 15min, so it makes sense to have booking time greater than 15 minutes.

Does this PR introduce a user-facing change?

Increase booking time for ProvisioningRequest to 20 minutes.

cc: @kisieland

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yaroslava-serdiuk Once this PR has been reviewed and has the lgtm label, please assign bigdarkclown for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[cluster-autoscaler/OWNERS](https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yaroslava-serdiuk commented 1 week ago

/hold

kisieland commented 1 week ago

/lgtm

k8s-ci-robot commented 1 week ago

@kisieland: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes/autoscaler/pull/6936#issuecomment-2186332878): >/lgtm > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.