Open eltociear opened 1 week ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: eltociear Once this PR has been reviewed and has the lgtm label, please assign kwiesmueller for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @eltociear. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
@eltociear, IMO we can't change the vendor directory, these dependencies are mostly coming from the k/k repo and are updated from there, this package has not been updated there yet https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/cm/util/cdi/cdi.go#L119
Once upstream is updated, then we can upgrade the VPA vendor directory.
cc @kwiesmueller @voelzmo PTAL!
Out of curiosity, what is the process to get a vendor directory updated? Is it this script: https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/hack/update-kubernetes-deps.sh
Out of curiosity, what is the process to get a vendor directory updated? Is it this script: https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/hack/update-kubernetes-deps.sh
IMO the script you mentioned above is updating the VPA vendor directory The script for updating the VPA e2e vendor directory is as follows: https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/hack/update-kubernetes-deps-in-e2e.sh
Out of curiosity, what is the process to get a vendor directory updated?
The purpose is to update/sync VPA dependencies corresponding to upstream repositories`.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: