search

kubernetes / autoscaler

Autoscaling components for Kubernetes
Apache License 2.0
7.8k stars 3.87k forks source link

Allow removing some volumes so that bounded PV check can pass when scaling down #6976

Open jewelzqiu opened 5 days ago

jewelzqiu commented 5 days ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #6417

Special notes for your reviewer:

Previous PR: #6418 Specifying --skip-nodes-with-local-storage=false won't help, because this flag only affects drainable check After drainable check, the pod will enter bounded PV check where it will fail (because local pv is bounded to the specified node)

Does this PR introduce a user-facing change?

Allow removing some volumes so that bounded PV check can pass when scaling down

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented 5 days ago

Hi @jewelzqiu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 5 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jewelzqiu Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[cluster-autoscaler/OWNERS](https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jewelzqiu commented 5 days ago

@x13n Hi, I have resubmitted the PR, because specifying --skip-nodes-with-local-storage=false won't help in the scenario of the original issue (bounded PV check will still fail)

jewelzqiu commented 5 days ago

@wackxu check this PR