search

kubernetes / autoscaler

Autoscaling components for Kubernetes
Apache License 2.0
7.8k stars 3.87k forks source link

Set State to InstanceCreating for nodes that failed to join cluster #6978

Open vbhargav875 opened 4 days ago

vbhargav875 commented 4 days ago

What type of PR is this?

/kind bug

What this PR does :

Cluster Autoscaler only handles deleting of cloud-provider instances that do not join the cluster within the max-node-provision-time only if the state of the cloud-provider instance is set to InstanceCreating. [Code Link]

This PR is set to the state of cloud-provider instance which have failed to InstanceCreating.

k8s-ci-robot commented 4 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vbhargav875 Once this PR has been reviewed and has the lgtm label, please assign jlamillan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[cluster-autoscaler/cloudprovider/oci/OWNERS](https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/oci/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 4 days ago

Hi @vbhargav875. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.