kubernetes / autoscaler

Autoscaling components for Kubernetes
Apache License 2.0
8.08k stars 3.97k forks source link

[Helm] Allow minAvailable to take precedence over default maxUnavailable in pdb of cluster-autoscaler helm chart #7128

Open ParichayDidwania opened 3 months ago

ParichayDidwania commented 3 months ago

Which component are you using?:

cluster-autoscaler helm chart

What version of the component are you using?:

9.37.0

Component version:

What k8s version are you using (kubectl version)?:

1.29

kubectl version Output
$ kubectl version

What environment is this in?:

AWS EKS

What did you expect to happen?:

When you set minAvailable, the helm chart fails to apply as the maxUnavailable is already defaulted in the values.yaml. The only work around is stated in ticket: #3779 where you need to set maxUnavailable = null to make it work.

What happened instead?:

Helm chart shouldn't fail to apply when you set only minAvailable field. The chart should prioritize to use minAvailable when provided and skip on maxUnavailable to be inserted into the pdb template.

How to reproduce it (as minimally and precisely as possible):

Install cluster-autoscaler helm chart and override the podDisruptionBudget.minAvailable=1

Anything else we need to know?:

This is something i faced while applying cluster autoscaler and I would like to raise a PR to fix this

Shubham82 commented 3 months ago

/area helm-charts /area cluster-autoscaler

k8s-triage-robot commented 1 week ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Shubham82 commented 1 week ago

/remove-lifecycle stale