cluster_autoscaler_failed_scale_ups_total metric is missing from metrics until an event is registered

elmiko commented 3 weeks ago

Which component are you using?:

cluster-autoscaler

What version of the component are you using?:

Component version: 1.29

What k8s version are you using (kubectl version)?:

1.29

What environment is this in?:

n/a

What did you expect to happen?:

metric should be initialized so that the zero value can be seen in prometheus data.

What happened instead?:

metric does not appear until it has been updated.

How to reproduce it (as minimally and precisely as possible):

start the CA
curl the metrics endpoint and grep for cluster_autoscaler_failed_scale_ups_total

Anything else we need to know?:

this should be fairly straightforward to fix.

elmiko commented 3 weeks ago

/area cluster-autoscaler

elmiko commented 3 weeks ago

/help-wanted /good-first-issue

k8s-ci-robot commented 3 weeks ago

@elmiko: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

Why are we solving this issue?
To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
Does this issue have zero to low barrier of entry?
How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubernetes/autoscaler/issues/7448): >/help-wanted >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

thiha-min-thant commented 3 weeks ago

Hi @elmiko , could you please assign to me? Thanks!

JoelSpeed commented 3 weeks ago

/assign @thiha-min-thant

kubernetes / autoscaler

cluster_autoscaler_failed_scale_ups_total metric is missing from metrics until an event is registered #7448

Guidelines