kubernetes / autoscaler

Autoscaling components for Kubernetes
Apache License 2.0
8.06k stars 3.97k forks source link

cluster_autoscaler_failed_scale_ups_total metric is missing from metrics until an event is registered #7448

Open elmiko opened 1 day ago

elmiko commented 1 day ago

Which component are you using?:

cluster-autoscaler

What version of the component are you using?:

Component version: 1.29

What k8s version are you using (kubectl version)?:

1.29

What environment is this in?:

n/a

What did you expect to happen?:

metric should be initialized so that the zero value can be seen in prometheus data.

What happened instead?:

metric does not appear until it has been updated.

How to reproduce it (as minimally and precisely as possible):

  1. start the CA
  2. curl the metrics endpoint and grep for cluster_autoscaler_failed_scale_ups_total

Anything else we need to know?:

this should be fairly straightforward to fix.

elmiko commented 1 day ago

/area cluster-autoscaler

elmiko commented 1 day ago

/help-wanted /good-first-issue

k8s-ci-robot commented 1 day ago

@elmiko: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubernetes/autoscaler/issues/7448): >/help-wanted >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
thiha-min-thant commented 22 hours ago

Hi @elmiko , could you please assign to me? Thanks!

JoelSpeed commented 17 hours ago

/assign @thiha-min-thant