search

kubernetes / client-go

Go client for Kubernetes.
Apache License 2.0
8.79k stars 2.91k forks source link

Feature request: Support labeled events in EventRecorder interface #1210

Closed odubajDT closed 3 months ago

odubajDT commented 1 year ago

Is there please a plan to support labeled Events in EventRecorder interface? Labels are the default filter objects for filtering in lists of k8s resources. It would be sufficient to have the option to set labels in Events, so users are able to filter them effectively.

PoC of the required functionality available here:

https://github.com/odubajDT/client-go/commit/44fc5c38a817d0585a4692e15413ddc1f6291a8d

Does this functionality have a chance to accepted by upstream?

Thank you very much.

Regads, Ondrej Dubaj

Jainbrt commented 1 year ago

hi @odubajDT thanks for raising this issue. are you planning to raise the PR so that community can get it fixed in coming release?

odubajDT commented 1 year ago

Hi @Jainbrt this feature was declined to be done after a discussion with the kubernetes maintainers

Jainbrt commented 1 year ago

I understand, do we have any other alternative to achieve the same ?

odubajDT commented 1 year ago

I guess this is a question on kubernetes maintainers, but AFAIK the current state requires to list all resources of the certain type via k8s API and filter them clinet-side

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

Jainbrt commented 1 year ago

/remove-lifecycle rotten

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 3 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/client-go/issues/1210#issuecomment-2016671596): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.