Closed nathanperkins closed 3 months ago
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/reopen
/remove-lifecycle rotten
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
@k8s-triage-robot: Closing this issue, marking it as "Not Planned".
The FakeRecorder for events has some slight gaps which can make it difficult to test.
strings.Contains
or parse it.IncludeObject
is set.I am working on a simple structured event recorder whose channel returns an
Event
struct, allowing much easier validation of expectations:I also have a
func ValidateEvents(gotEvents, wantEvents []Event) error
that was suitable for most of my testing. I'm a little more hesitant to contribute this since the validation is more opinionated and depends on the use case. In my validation:Object
,MessageFormat
andMessageArgs
are ignored.want.Message
is present, checkstrings.Contains(got.Message, want.Message)
.I'm curious if others would find these useful enough to contribute. If so, let me know where to put it and I can submit a PR.