search

kubernetes / client-go

Go client for Kubernetes.
Apache License 2.0
8.78k stars 2.9k forks source link

gnostic to gnostic-models switch is breaking code #1265

Closed joshelb closed 1 year ago

joshelb commented 1 year ago

https://github.com/kubernetes/client-go/blob/master/discovery/cached/disk/cached_discovery.go#L238

The import for openapiv2 has to be updated to gnostic-models

openapi_v2 "github.com/google/gnostic/openapiv2 to openapi_v2 "github.com/google/gnostic-models/openapiv2

Maybe this also needs to be updated in other parts im nmot sure yet.

Jefftree commented 1 year ago

This has been updated in the latest release v0.28-alpha.2

/close

k8s-ci-robot commented 1 year ago

@Jefftree: Closing this issue.

In response to [this](https://github.com/kubernetes/client-go/issues/1265#issuecomment-1584806077): >This has been updated in the latest release v0.28-alpha.2 > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.