search

kubernetes / client-go

Go client for Kubernetes.
Apache License 2.0
8.99k stars 2.94k forks source link

TimeoutSeconds from metav1.ListOptions{} doesn't work as expected. #1292

Closed Kulagin-G closed 6 months ago

Kulagin-G commented 1 year ago

There is a part of my code where I use *dynamic.DynamicClient client with List resources by requested parameters:

start := time.Now()
apps, err := g.k8sClient.
Resource(appGVR).
Namespace(g.cfg.KubeApi.MetricConfig.Namespace).
List(context.TODO(),
    metav1.ListOptions{
        LabelSelector:  g.cfg.KubeApi.MetricConfig.LabelSelector,
        FieldSelector:  g.cfg.KubeApi.MetricConfig.FieldSelector,
        TimeoutSeconds: &g.cfg.KubeApi.MetricConfig.TimeoutSeconds,
        Limit:          g.cfg.KubeApi.MetricConfig.Limit,
    },
)
elapsed := time.Since(start).Seconds()

The real request time can take about 5s, and even if I set TimeoutSeconds to 1s I don't see any effect.

Based on my quick research:

  1. We add TimeoutSeconds as a url.Values param value to the*rest.Request object during request preparation- https://github.com/kubernetes/client-go/blob/v0.27.4/rest/request.go#L372
  2. Next client invokes Do() method with timeout set as default value 0 every time - https://github.com/kubernetes/client-go/blob/master/rest/request.go#L1061
  3. req.URL.Query() example - labelSelector=prometheus%2Fis-infra-app-metric%3Dtrue%2Capplications.argoproj.io%2Ftemplate_type%3Dapplication&timeoutSeconds=1

I'm not sure request.timeout should be overridden, but this timeout is being used in context for dropping a request that looks like a target place to override with value from metav1.ListOptions - https://github.com/kubernetes/client-go/blob/v0.27.4/rest/request.go#L969

Correct me please if I'm wrong. Thank you!

P.S. I use the latest release version k8s.io/client-go@v0.27.4, the same behavior for the latest v0.29.0-alpha.0 P.S.S. LabelSelector string is also being added to r.params and works as expected.

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 6 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/client-go/issues/1292#issuecomment-2019886220): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.