kubernetes / client-go

Go client for Kubernetes.
Apache License 2.0
8.99k stars 2.94k forks source link

chore(docs): refresh compatibility matrix #1294

Closed dnwe closed 7 months ago

dnwe commented 1 year ago

Bring the compatibility matrix up-to-date with more recent versions of Kubernetes

Fixes #1069

linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 1 year ago

Welcome @dnwe!

It looks like this is your first PR to kubernetes/client-go 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/client-go has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 year ago

Hi @dnwe. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
yliaog commented 1 year ago

/ok-to-test

yliaog commented 1 year ago

/lgtm /approve

dnwe commented 1 year ago

@yliaog seems like 'pull-client-go-build' is using a go version older than 1.16 and hence can't find the io/fs pkg (that was new in 1.16). I guess this build infra hasn't been updated in a while as changes don't usually come direct to this repo

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

dnwe commented 8 months ago

/remove-lifecycle stale

dnwe commented 8 months ago

@yliaog can we revisit this?

yliaog commented 8 months ago

could you rebase the PR?

dnwe commented 8 months ago

Sure, rebased now

dnwe commented 8 months ago

As previously mentioned, the pull-client-go-build is broken because it's still using Go 1.16 and the master branch of client-go needs at least 1.21 now due to a dependency on the builtin cmp package

I raised https://github.com/kubernetes/test-infra/pull/31713 to bump it

dnwe commented 8 months ago

/retest

cblecker commented 7 months ago

@yliaog looks like this one is ready for review again

/triage accepted

yliaog commented 7 months ago

/lgtm /approve

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dnwe, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/client-go/blob/master/OWNERS)~~ [yliaog] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yliaog commented 7 months ago

1.29 has been released, and should be added, but that can be done later.