kubernetes / client-go

Go client for Kubernetes.
Apache License 2.0
9.12k stars 2.95k forks source link

Should remove pod not deployment. #1384

Closed fndcz closed 4 weeks ago

fndcz commented 1 month ago

There's no deployment created but a single pod, so to clean up it we should remove the pod not the deployment.

Sorry, we do not accept changes directly against this repository, unless the change is to the README.md itself. Please see CONTRIBUTING.md for information on where and how to contribute instead.

linux-foundation-easycla[bot] commented 1 month ago

CLA Not Signed

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fndcz Once this PR has been reviewed and has the lgtm label, please assign liggitt for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/client-go/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 month ago

Welcome @fndcz!

It looks like this is your first PR to kubernetes/client-go 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/client-go has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

Jefftree commented 4 weeks ago

Please send a PR to https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/examples/in-cluster-client-configuration/README.md instead of client-go. This repo is mirrored from the kubernetes/kubernetes project

/close

k8s-ci-robot commented 4 weeks ago

@Jefftree: Closed this PR.

In response to [this](https://github.com/kubernetes/client-go/pull/1384#issuecomment-2444959242): >Please send a PR to https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/examples/in-cluster-client-configuration/README.md instead of client-go. This repo is mirrored from the `kubernetes/kubernetes` project > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.