search

kubernetes / cloud-provider-alibaba-cloud

CloudProvider for Alibaba Cloud
Apache License 2.0
360 stars 163 forks source link

`--version` flag is broken #257

Closed ialidzhikov closed 2 years ago

ialidzhikov commented 3 years ago

/kind bug /sig cloud-provider

What happened:

--version flag does not report the correct component version.

Ref https://github.com/kubernetes/cloud-provider/issues/49.

What you expected to happen:

--version to report the correct component version.

How to reproduce it (as minimally and precisely as possible):

$ make cloud-controller-manager
$ ./alibaba-cloud-ccm --version
Kubernetes v0.0.0-master+$Format:%h$
$ ./alibaba-cloud-ccm --version=raw
version.Info{Major:"", Minor:"", GitVersion:"v0.0.0-master+$Format:%h$", GitCommit:"$Format:%H$", GitTreeState:"", BuildDate:"1970-01-01T00:00:00Z", GoVersion:"go1.16.5", Compiler:"gc", Platform:"darwin/amd64"}

Environment: alicloud-cloud-controller-manager version: d6d0962b4be051c7dc536dc7e49ad0aff018ef3b

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ialidzhikov commented 2 years ago

/remove-lifecycle stale

gujingit commented 2 years ago

Thanks for reminding, it has been fixed in v2.1.0

ialidzhikov commented 2 years ago

Thanks for reminding, it has been fixed in v2.1.0

Is it?

docker run registry.cn-hangzhou.aliyuncs.com/acs/cloud-controller-manager-amd64:v2.1.0 --version
I0101 13:07:25.346396       1 main.go:36]  "msg"="Cloud Controller Manager Version: v2.1.0, git commit: c9ed1fee10f0fcaa9b6f460539878334ffeaa628, build date: 2021-11-23T10:23:59+0800"
I0101 13:07:25.346453       1 main.go:38]  "msg"="Go Version: go1.16.10"
I0101 13:07:25.346459       1 main.go:39]  "msg"="Go OS/Arch: linux/amd64"
I0101 13:07:25.346463       1 main.go:40]  "msg"="Version of operator-sdk: v0.19.4"
unknown flag: --version
Usage of :
unknown flag: --version
      --add_dir_header                           If true, adds the file directory to the header
      --alsologtostderr                          log to standard error as well as files
      --cloud-config string                      The path to the cloud provider configuration file. Empty string for no configuration file.
      --cloud-provider string                    The provider for cloud services. Empty string for no provider. (default "alibabacloud")
      --cluster-cidr string                      CIDR Range for Pods in cluster. Requires --allocate-node-cidrs to be true.
      --cluster-name string                      The instance prefix for the cluster. (default "kubernetes")
      --concurrent-service-syncs int             Maximum number of concurrently running reconcile loops for service (default 3)
      --configure-cloud-routes                   Should CIDRs allocated by allocate-node-cidrs be configured on the cloud provider. (default true)
      --controllers strings                      A list of controllers to enable. (default [node,route,service])
      --dry-run                                  whether to perform a dry run
      --feature-gates string                     A set of key=value pairs that describe feature gates for alpha/experimental features.
      --health-probe-bind-addr string            The address the health probes binds to. (default ":10258")
      --kube-api-burst int                       Burst to use while talking with kubernetes apiserver. (default 30)
      --kube-api-qps float32                     QPS to use while talking with kubernetes apiserver. (default 20)
      --kubeconfig string                        Paths to a kubeconfig. Only required if out-of-cluster.
      --leader-elect                             Start a leader election client and gain leadership before executing the main loop. Enable this when running replicated components for high availability. (default true)
      --leader-elect-lease-duration duration     he duration that non-leader candidates will wait after observing a leadership renewal until attempting to acquire leadership of a led but unrenewed leader slot. This is effectively the maximum duration that a leader can be stopped before it is replaced by another candidate. This is only applicable if leader election is enabled. (default 15s)
      --leader-elect-renew-deadline duration     The interval between attempts by the acting master to renew a leadership slot before it stops leading. Thismust be less than or equal to the lease duration. This is only applicable if leader election is enabled. (default 10s)
      --leader-elect-resource-lock string        The type of resource object that is used for locking during leader election. Supported options are 'endpoints', 'configmaps', 'leases', 'endpointsleases' and 'configmapsleases' (default "endpointsleases")
      --leader-elect-resource-name string        The name of resource object that is used for locking during leader election.  (default "ccm")
      --leader-elect-resource-namespace string   The namespace of resource object that is used for locking during leader election. (default "kube-system")
      --leader-elect-retry-period duration       The duration the clients should wait between attempting acquisition and renewal of a leadership. This is onlyapplicable if leader election is enabled. (default 2s)
      --log_backtrace_at traceLocation           when logging hits line file:N, emit a stack trace (default :0)
      --log_dir string                           If non-empty, write log files in this directory
      --log_file string                          If non-empty, use this log file
      --log_file_max_size uint                   Defines the maximum size a log file can grow to. Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
      --logtostderr                              log to standard error instead of files (default true)
      --metrics-bind-addr string                 The address the metric endpoint binds to. (default ":8080")
      --network string                           Set network type for controller. (default "vpc")
      --node-monitor-period duration             The period for syncing NodeStatus in NodeController. (default 5m0s)
      --route-reconciliation-period duration     The period for reconciling routes created for nodes by cloud provider. The minimum value is 1 minute (default 5m0s)
      --skip_headers                             If true, avoid header prefixes in the log messages
      --skip_log_headers                         If true, avoid headers when opening log files
      --stderrthreshold severity                 logs at or above this threshold go to stderr (default 2)
      --sync-period duration                     Period at which the controller forces the repopulation of its local object stores. (default 1h0m0s)
      --use-service-account-credentials          If true, use individual service account credentials for each controller.
  -v, --v Level                                  number for the log level verbosity
      --vmodule moduleSpec                       comma-separated list of pattern=N settings for file-filtered logging

It says unknown flag: --version and yields the whole usage help.

gujingit commented 2 years ago

We do not support --version flag. If you want to check the ccm version, pls run docker run registry.cn-hangzhou.aliyuncs.com/acs/cloud-controller-manager-amd64:v2.1.0 version

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closing this issue.

In response to [this](https://github.com/kubernetes/cloud-provider-alibaba-cloud/issues/257#issuecomment-1191392813): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.