kubernetes / cloud-provider-alibaba-cloud

CloudProvider for Alibaba Cloud
Apache License 2.0
360 stars 163 forks source link

Support modifying lbInstanceChargeType from cu to spec #326

Closed Lyt99 closed 2 years ago

Lyt99 commented 2 years ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add ability to change LoadBalancer charge type from PayByCLCU to PayBySpec

k8s-ci-robot commented 2 years ago

Welcome @Lyt99!

It looks like this is your first PR to kubernetes/cloud-provider-alibaba-cloud 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-alibaba-cloud has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 2 years ago

Hi @Lyt99. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gujingit commented 2 years ago

/approve /lgtm

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gujingit, Lyt99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-alibaba-cloud/blob/master/OWNERS)~~ [gujingit] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Lyt99 commented 2 years ago

/test

k8s-ci-robot commented 2 years ago

@Lyt99: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/kubernetes/cloud-provider-alibaba-cloud/pull/326#issuecomment-1219193663): >/test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gujingit commented 2 years ago

/lgtm

gujingit commented 2 years ago

/ok-to-test

gujingit commented 2 years ago

/ok-to-test

k8s-ci-robot commented 2 years ago

@Lyt99: The /test command needs one or more targets. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubernetes/cloud-provider-alibaba-cloud/pull/326#issuecomment-1219407449): >/test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Lyt99 commented 2 years ago

/test all

gujingit commented 2 years ago

/lgtm