kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
385 stars 301 forks source link

Add e2e testing of cloud provider via Cluster API Clusterctl framework or Cluster API kubetest2 deployer #130

Open randomvariable opened 3 years ago

randomvariable commented 3 years ago

What would you like to be added: Add e2e conformance testing to this repo

Why is this needed: Discussed a while ago about testing requirements for this repo, and had demo'd launching kubetest via Cluster API's clusterctl framework. Inclusion of conformance testing is almost complete (see https://github.com/kubernetes-sigs/cluster-api/pull/3652), and am considering adding a Cluster API deployer to kubetest2 ( https://github.com/kubernetes-sigs/kubetest2/issues/48 ).

This could be used to then set up e2e testing on this repo.

/kind feature

randomvariable commented 3 years ago

/assign

randomvariable commented 3 years ago

https://github.com/kubernetes-sigs/cluster-api/pull/3652 is in, and https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/1991 serves as an example to consume, so can probably start adding similar here.

Will probably naively try spinning up Cluster API AWS cluster with external CPI, pass the kubeconfig to a new goroutine to run the CPI and then run the relevant kubetest bits.

randomvariable commented 3 years ago

/lifecycle active

randomvariable commented 3 years ago

Hah, I started playing around with a kubetest2 deployer, but @benmoss is already ahead in https://github.com/kubernetes-sigs/kubetest2/issues/48#issuecomment-708675720

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

randomvariable commented 3 years ago

/lifecycle frozen

Will be getting round to this next week,.