Open randomvariable opened 3 years ago
@randomvariable Thanks for reaching out. I think we can keep same format(i'm open to new metrics if applicable) :D
@M00nF1sh Are we ok to copy the throttle package over to this repo and cluster-api?
@randomvariable of course. but i do think the throttle package needs some enhancements. e.g. it should use endpointID instead of serviceName when throttling. since some service's serviceName have space within it.
/assign
I spoke with @jaypipes and he is going to create a repository under the aws organization to put the throttle package and any other widely shared utils. @M00nF1sh WDYT about that?
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale
@jaypipes has any progress been made on creating the repo to include importable limiters?
/lifecycle frozen
What would you like to be added: Follow up from #131, add AWS request handlers to do the following:
@M00nF1sh , do you think it's worth re-implementing what's done in in https://github.com/aws/aws-app-mesh-controller-for-k8s/tree/master/pkg/aws for the above?
FWIW, I used the same metric formats in https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/master/pkg/cloud/metrics/metrics.go, so would be worth standardising.
Why is this needed:
/kind feature