kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
382 stars 301 forks source link

Add request handlers to v2 implementation #137

Open randomvariable opened 3 years ago

randomvariable commented 3 years ago

What would you like to be added: Follow up from #131, add AWS request handlers to do the following:

@M00nF1sh , do you think it's worth re-implementing what's done in in https://github.com/aws/aws-app-mesh-controller-for-k8s/tree/master/pkg/aws for the above?

FWIW, I used the same metric formats in https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/master/pkg/cloud/metrics/metrics.go, so would be worth standardising.

Why is this needed:

/kind feature

M00nF1sh commented 3 years ago

@randomvariable Thanks for reaching out. I think we can keep same format(i'm open to new metrics if applicable) :D

randomvariable commented 3 years ago

@M00nF1sh Are we ok to copy the throttle package over to this repo and cluster-api?

M00nF1sh commented 3 years ago

@randomvariable of course. but i do think the throttle package needs some enhancements. e.g. it should use endpointID instead of serviceName when throttling. since some service's serviceName have space within it.

randomvariable commented 3 years ago

/assign

nckturner commented 3 years ago

I spoke with @jaypipes and he is going to create a repository under the aws organization to put the throttle package and any other widely shared utils. @M00nF1sh WDYT about that?

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

randomvariable commented 3 years ago

@jaypipes has any progress been made on creating the repo to include importable limiters?

randomvariable commented 3 years ago

/lifecycle frozen