Kubelet 1.27.x failing to get credentials when credentialprovider.kubelet.k8s.io/v1 api is used

[ikolomiyets]

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind bug

What this PR does / why we need it: CredentialProvider API has been updated to v1 since 1.26 however the ecr-credential-provider still expects credentialprovider.kubelet.k8s.io/v1alpha1 version.

Which issue(s) this PR fixes:

Fixes # 596

Special notes for your reviewer:

Does this PR introduce a user-facing change?: NONE

- Credential Provider Config file should be modified in the existing installations to reflect changes in the API version

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: ikolomiyets / name: Igor Kolomiyets (c66a2e61323a26fbb0031b58a3b694480fba8957, e6a18cabdf954820e0b69d08e5434eb652e6efb2)

[k8s-ci-robot]

Welcome @ikolomiyets!

It looks like this is your first PR to kubernetes/cloud-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @ikolomiyets. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[dims]

/ok-to-test

[dims]

/assign @olemarkus @nckturner @hakman

[dims]

xref: https://github.com/kubernetes/cloud-provider-aws/issues/596

[dims]

/kind bug /triage accepted

[nckturner]

/lgtm

[nckturner]

/assign @cartermckinnon for quick review then I'll approve

[k8s-ci-robot]

@cartermckinnon: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes/cloud-provider-aws/pull/597#pullrequestreview-1388926724): >Looks fine to me. Ideally we'd continue supporting the other API versions, as Kubelet does, but it'd muck up the code significantly and this is easy enough to handle when upgrading to 1.27. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[nckturner]

Looks fine to me. Ideally we'd continue supporting the other API versions, as Kubelet does, but it'd muck up the code significantly and this is easy enough to handle when upgrading to 1.27.

Yeah it forces an upgrade as is, but ... I think that's ok? We do need to call it out in release notes though.

[nckturner]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cartermckinnon, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/master/OWNERS)~~ [nckturner] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment