Closed mmerkes closed 1 year ago
This issue is currently awaiting triage.
If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted
label and provide further guidance.
The triage/accepted
label can be added by org members by writing /triage accepted
in a comment.
Hi @mmerkes. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
cc @jlbutler
/approve
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dims, nckturner
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this? /kind feature
What this PR does / why we need it: ecr-credential-provider can now authenticate public registries, which allows users to access larger ECR data transfer limits. See #602 for more details. This will not work outside of the
aws
partition as the ECR public endpoint is only inus-east-1
and it requires IAM authentication.To enable this, you may need a couple of changes in your nodes:
public.ecr.aws
tomatchImages
in yourCredentialProviderConfig
. See below for an example.ecr-public:GetAuthorizationToken
andsts:GetServiceBearerToken
permissions. See below for an example policy.Which issue(s) this PR fixes:
Fixes #602
Special notes for your reviewer:
For testing, I created a 1.26 EKS cluster with an AL2 nodegroup in
us-west-2
, built theecr-credential-provider
, uploaded to the nodes and used the below image credential provider config:I deployed the EKS sample app and verified the following:
GetAuthorizationToken
to private ECR registry endpoint showed up inus-west-2
GetAuthorizationToken
to public ECR registry endpoint showed up inus-east-1
Does this PR introduce a user-facing change?: