Update ecr plugin to use credential provider v1beta1 for K8s 1.24/1.25/1.26

kubernetes / cloud-provider-aws

Cloud provider for AWS

https://cloud-provider-aws.sigs.k8s.io/

Apache License 2.0

387 stars 301 forks source link

Update ecr plugin to use credential provider v1beta1 for K8s 1.24/1.25/1.26 #606

Closed ArchitKhanna closed 8 months ago

ArchitKhanna commented 1 year ago

What would you like to be added: The credential provider was upgraded to v1beta1 in K8s 1.24 (source) However the ecr-credential-provider plugin still implements v1alpha1. This should be updated to v1beta1.

Why is this needed: Since credential provider v1beta1 is the newest supported version in K8s 1.24, 1.25 and 1.26, we should be using it for the plugin as well to stay updated.

/kind feature

k8s-ci-robot commented 1 year ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

kmala commented 1 year ago

Its updated to v1 and released as part of 1.27.1 https://github.com/kubernetes/cloud-provider-aws/commit/c66a2e61323a26fbb0031b58a3b694480fba8957

ArchitKhanna commented 1 year ago

@kmala I am using K8s 1.25.9 and for compatibility I have to use the cloud-provider-aws version 1.25 right? Which means the Credential Provider should be updated to v1beta1? Or am I understanding the usage incorrectly?

cartermckinnon commented 1 year ago

@ArchitKhanna the ECR credential provider doesn't really have the same versioning semantics as the AWS cloud-controller-manager -- the only thing that matters for compatibility is the API version between it and the kubelet. (In fact, the ECR cred provider had no version introspection until recently, in #607).

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

cartermckinnon commented 8 months ago

/close not-planned

k8s-ci-robot commented 8 months ago

@cartermckinnon: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/cloud-provider-aws/issues/606#issuecomment-1908813623): >/close not-planned Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.