kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
395 stars 302 forks source link

Add version flag to ecr-credential-provider #607

Closed cartermckinnon closed 1 year ago

cartermckinnon commented 1 year ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

The ecr-credential-provider has recently changed the API version it supports (#597). Currently, there is no straightforward way to distinguish two ecr-credential-provider binaries, which makes changes like #597 difficult to handle. This PR adds a --version flag that returns the standard gitVersion as in k8s.io/component-base/version, to help in such situations.

Special notes for your reviewer:

I ran go mod vendor, which did...a lot of things. Should I back those changes out? Removed.

Does this PR introduce a user-facing change?:

Yes.

A `--version` flag has been added to the `ecr-credential-provider`.
k8s-ci-robot commented 1 year ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

Welcome @cartermckinnon!

It looks like this is your first PR to kubernetes/cloud-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 year ago

Hi @cartermckinnon. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dims commented 1 year ago

@cartermckinnon love the idea. please drop the vendor/ directory?

dims commented 1 year ago

/ok-to-test

can you please paste output of both ecr-credential-provider and ecr-credential-provider --version so we can see how it looks?

cartermckinnon commented 1 year ago

Example output:

> ecr-credential-provider --help
ECR credential provider for kubelet

Usage:
  ecr-credential-provider [flags]

Flags:
  -h, --help      help for ecr-credential-provider
  -v, --version   version for ecr-credential-provider
> ecr-credential-provider --version
ecr-credential-provider version v1.27.1-8-gb80e8ef-dirty
dims commented 1 year ago

/approve

thanks @cartermckinnon

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/master/OWNERS)~~ [dims] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dims commented 1 year ago

/lgtm