search

kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
395 stars 302 forks source link

Add template annotations to daemonset #619

Closed kkonnov closed 1 year ago

kkonnov commented 1 year ago

What type of PR is this? /kind feature

What this PR does / why we need it: Ability to specify pod annotations in templates.

Special notes for your reviewer: NONE

Does this PR introduce a user-facing change?: NONE

k8s-ci-robot commented 1 year ago

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
linux-foundation-easycla[bot] commented 1 year ago

CLA Missing ID CLA Not Signed

k8s-ci-robot commented 1 year ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

Welcome @kkonnov!

It looks like this is your first PR to kubernetes/cloud-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 year ago

Hi @kkonnov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign nckturner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
linux-foundation-easycla[bot] commented 1 year ago

CLA Missing ID CLA Not Signed

STASiAN commented 1 year ago

/check-cla

kkonnov commented 1 year ago

@hakman @jaypipes Hi. Please tell me if I need to take additional steps to make my PR merged. I've already fix easyCLA, but can't see any actions here. Thank you in advance.

cartermckinnon commented 1 year ago

Looks reasonable.

/ok-to-test /check-cla

cartermckinnon commented 1 year ago

@kkonnov you'll need to amend your commit and correct the email address (or add that email to your GitHub profile) to fix the CLA check.

olemarkus commented 1 year ago

This needs release notes.

hakman commented 1 year ago

/check-cla /easy-cla

kkonnov commented 1 year ago

I've made correct email as a primary. How to re-run CLA-check? Or it will update automatically? @hakman

hakman commented 1 year ago

/check-cla /easy-cla

kkonnov commented 1 year ago

/check-cla

kkonnov commented 1 year ago

/check-cla

kkonnov commented 1 year ago

/easy-cla

kkonnov commented 1 year ago

Guys:

but faced the same issue. Please help me. What am I doing wrong?

hakman commented 1 year ago

@kkonnov We are not able to help here. Please create a support ticket as described in the above comment: https://github.com/kubernetes/cloud-provider-aws/pull/619#issuecomment-1588710259.

kkonnov commented 1 year ago

I got tired of fighting this MR and created a new one. https://github.com/kubernetes/cloud-provider-aws/pull/636 There CLA - went through successfully. This MR will be closed. Thanks for your help.