search

kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
395 stars 302 forks source link

Add IPv6 addresses to node addresses list #639

Closed james-callahan closed 1 year ago

james-callahan commented 1 year ago

What type of PR is this? /kind bug

What this PR does / why we need it:

Add IPv6 addresses to node addresses list in the v2 provider

Which issue(s) this PR fixes:

Fixes #638

Special notes for your reviewer:

I'm not sure if this should be considered a bugfix or a feature.

Does this PR introduce a user-facing change?:

fix support for IPv6 addresses in v2 provider
k8s-ci-robot commented 1 year ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

Welcome @james-callahan!

It looks like this is your first PR to kubernetes/cloud-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 year ago

Hi @james-callahan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kishorj for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
olemarkus commented 1 year ago

I see this PR goes against v2, which has sort of been abandoned. This feature is already available in v1.

james-callahan commented 1 year ago

I see this PR goes against v2, which has sort of been abandoned. This feature is already available in v1.

I've been using v2 happily for some time now. Last time I tried out v1 there was something that didn't work well... I can't remember what it was off the top of my head.

In any case, this PR should fix a missing piece of functionality from v2.

james-callahan commented 1 year ago

@olemarkus is there something I can do to help get this merged?

olemarkus commented 1 year ago

Sorry, I'm not approving PRs against v2. I only maintain v1.

cartermckinnon commented 1 year ago

Going to close this in light of #677.

/close

k8s-ci-robot commented 1 year ago

@cartermckinnon: Closed this PR.

In response to [this](https://github.com/kubernetes/cloud-provider-aws/pull/639#issuecomment-1765619768): >Going to close this in light of #677. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.