Closed dims closed 1 year ago
This issue is currently awaiting triage.
If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted
label and provide further guidance.
The triage/accepted
label can be added by org members by writing /triage accepted
in a comment.
/assign @kmala @tzneal @nckturner
@dims: GitHub didn't allow me to assign the following users: kmala.
Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: tzneal Once this PR has been reviewed and has the lgtm label, please ask for approval from dims. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/lgtm
/retest
@dims: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-cloud-provider-aws-e2e | 3428ad49ad5d338a69e21a7bf70de11d40f72435 | link | true | /test pull-cloud-provider-aws-e2e |
pull-cloud-provider-aws-e2e-kubetest2 | 3428ad49ad5d338a69e21a7bf70de11d40f72435 | link | false | /test pull-cloud-provider-aws-e2e-kubetest2 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
I am still working on the CI jobs :) so merging this by hand.
/approve 😄
Same change that we did earlier here: https://github.com/kubernetes/cloud-provider-aws/commit/2346f203ce325913ef8ed8d19b6283495ae43749#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R23
What type of PR is this? /kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: