search

kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
395 stars 302 forks source link

Remove ecr pattern restriction #673

Closed jBouyoud closed 1 year ago

jBouyoud commented 1 year ago

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

Remove ecr pattern restriction and forward region responsability to AWS SDK default behavior. This allow users to use this binary with any registries even they configure properly their AWS SDK (AWS_REGION environment variable or any other configuration handled in AWS SDK)

Which issue(s) this PR fixes:

Fixes #668

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[ecr-credential-provider] An ECR token is returned for the default AWS region when the specified image reference doesn't match a known ECR pattern.
linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 1 year ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

Welcome @jBouyoud!

It looks like this is your first PR to kubernetes/cloud-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 year ago

Hi @jBouyoud. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
hakman commented 1 year ago

/cc @cartermckinnon @dims /ok-to-test

cartermckinnon commented 1 year ago

@jBouyoud we need a release note on this as well.

cartermckinnon commented 1 year ago

Suggested change to the release note:

[ecr-credential-provider] An ECR token is returned for the default AWS region when the specified image reference doesn't match a known ECR pattern.
cartermckinnon commented 1 year ago

/lgtm

cartermckinnon commented 1 year ago

/assign @tzneal

can you give this a look?

hakman commented 1 year ago

/cc @olemarkus

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/master/OWNERS)~~ [olemarkus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment