search

kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
395 stars 302 forks source link

Automated cherry pick of #667: Handle private ECR image references containing public.ecr.aws #682

Closed cartermckinnon closed 1 year ago

cartermckinnon commented 1 year ago

Cherry pick of #667 on release-1.27.

667: Handle private ECR image references containing public.ecr.aws

For details on the cherry pick process, see the cherry pick requests page.

k8s-ci-robot commented 1 year ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kishorj for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/release-1.27/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 year ago

@cartermckinnon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-aws-check bd9e1ec330917d93b7f184fe1825543f6eb8b6a7 link true /test pull-cloud-provider-aws-check
pull-cloud-provider-aws-test bd9e1ec330917d93b7f184fe1825543f6eb8b6a7 link true /test pull-cloud-provider-aws-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
cartermckinnon commented 1 year ago

The lack of #603 on this branch is breaking this patch. I'll get it cleaned up today.

cartermckinnon commented 1 year ago

My coffee must not have kicked in yet -- we don't need this fix in 1.27 and lower, because the bug doesn't exist there -- the bug was introduced in #603 .