kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
395 stars 302 forks source link

[release-1.24] Update k8s.io/cloud-provider, golang.org/x/net #690

Closed cartermckinnon closed 1 year ago

cartermckinnon commented 1 year ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

1.24 is EOL in k/k -- this PR updates this repo to the last 1.24 dependency version. It also pulls in a fix for golang/x/net while we're at it. We should cut one more 1.24 release.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?: NONE

k8s-ci-robot commented 1 year ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cartermckinnon commented 1 year ago

/release-note-none

cartermckinnon commented 1 year ago

/retest

cartermckinnon commented 1 year ago

Test seems to be broken by: https://github.com/kubernetes/kops/commit/47b1c370693179e4152521e498d5b8a4e21583ef, or changes associated with this commit

 Error: field spec.cloudProvider.aws.ebsCSIDriver.enabled not found in *Cluster 
cartermckinnon commented 1 year ago

Got a fix up in #691 .

hakman commented 1 year ago

/retest

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/release-1.24/OWNERS)~~ [hakman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment