search

kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
395 stars 302 forks source link

[release-1.28] Automated cherry pick of #674: do not allow ec2 instance ID not found in tagging path #694

Closed ndbaker1 closed 1 year ago

ndbaker1 commented 1 year ago

Cherry pick of #674 on release-1.28.

674: do not allow ec2 instance ID not found in tagging path

For details on the cherry pick process, see the cherry pick requests page.

Fixes an issue where `InvalidInstanceID.NotFound` error did not re-queue the tagging work item
k8s-ci-robot commented 1 year ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

Hi @ndbaker1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cartermckinnon commented 1 year ago

/ok-to-test /lgtm

cartermckinnon commented 1 year ago

@ndbaker1 can you go ahead and open cherry-picks for the other versions you want this in? I'd like to cut a release on all the branches later this week, we might as well get this into that one.

ndbaker1 commented 1 year ago

@ndbaker1 can you go ahead and open cherry-picks for the other versions you want this in? I'd like to cut a release on all the branches later this week, we might as well get this into that one.

looks like issue occurred on 1.23, so going to open for supported versions 1.23-1.28

cartermckinnon commented 1 year ago

The 1.23 CI is broken (kops no longer supports 1.23), so we'll either have to pin an older kops image or leave 1.23 as-is.

/retitle [release-1.28] Automated cherry pick of #674: do not allow ec2 instance ID not found in tagging path #694

cartermckinnon commented 1 year ago

/retitle [release-1.28] Automated cherry pick of #674: do not allow ec2 instance ID not found in tagging path

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/release-1.28/OWNERS)~~ [hakman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment