search

kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
395 stars 302 forks source link

duplicate functionality with Load Balancer Controller #728

Closed riuvshyn closed 5 months ago

riuvshyn commented 1 year ago

Hello, I am abit confused by the fact that AWS cloud provider is having similar functionality as Load Balancer Controller

If I have both aws cloud provider and aws lb controller running which component should be responsible for serving k8s Service annotations? https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.6/guide/service/annotations/ https://cloud-provider-aws.sigs.k8s.io/service_controller/ Both seems to have service controllers using same annotations...

/triage support

k8s-ci-robot commented 1 year ago

@riuvshyn: The label(s) triage/support cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes/cloud-provider-aws/issues/728): >Hello, I am abit confused by the fact that AWS cloud provider is having similar functionality as [Load Balancer Controller](https://github.com/kubernetes-sigs/aws-load-balancer-controller/) > >If I have both aws cloud provider and aws lb controller running which component should be responsible for serving k8s Service annotations? >https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.6/guide/service/annotations/ >https://cloud-provider-aws.sigs.k8s.io/service_controller/ >Both seems to have service controllers using same annotations... > >/triage support > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
taraszka commented 1 year ago

Yeah, it would be nice to have a switch that would disable the functionality of the Load Balancer Controller here...

kmala commented 1 year ago

/assign @M00nF1sh @oliviassss

oliviassss commented 12 months ago

@riuvshyn, @taraszka, from AWS LBC v2.5.0 we add a webhook mutator to make the LBC the default controlle for service type of load balancer, to disable this feature you can set the helm chart value enableServiceMutatorWebhook to false. see more details from our release note: https://github.com/kubernetes-sigs/aws-load-balancer-controller/releases/tag/v2.5.0

taraszka commented 12 months ago

@oliviassss I know, I'd like to have the same for cloud-provider-aws, and let decide which to use using LoadBalancerClass

riuvshyn commented 12 months ago

@oliviassss same here, I want let LB controller to manage LBs not the CCM. 🙇🏽

JoelSpeed commented 10 months ago

Have you tried configuring the --controllers flag for the CCM? I believe --controllers=*,-service would disable the service controller, leaving all functionality then to the LB controller no?

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 5 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/cloud-provider-aws/issues/728#issuecomment-2145971110): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.