kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
395 stars 302 forks source link

fix(pkg/controllers/tagging): correct logging message for seconds #731

Closed gyuho closed 12 months ago

gyuho commented 12 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it: Similar to https://github.com/kubernetes/cloud-provider-aws/pull/712, fix logging format.

I1107 17:47:44.958671 11 tagging_controller.go:250] Processing latency %!s(float64=0.565427747)

should be "Processing latency 0.565427747 seconds".

Which issue(s) this PR fixes: N/A

Special notes for your reviewer: Thanks.

Does this PR introduce a user-facing change?:

NONE
k8s-ci-robot commented 12 months ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kmala commented 12 months ago

/lgtm

k8s-ci-robot commented 12 months ago

@kmala: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes/cloud-provider-aws/pull/731#issuecomment-1799348721): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kmala commented 12 months ago

/triage accepted

k8s-ci-robot commented 12 months ago

@kmala: The label triage/accepted cannot be applied. Only GitHub organization members can add the label.

In response to [this](https://github.com/kubernetes/cloud-provider-aws/pull/731#issuecomment-1799349636): >/triage accepted Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cartermckinnon commented 12 months ago

/lgtm /approve

k8s-ci-robot commented 12 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cartermckinnon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/master/OWNERS)~~ [cartermckinnon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment