search

kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
395 stars 302 forks source link

cherry pick of #740 update otel-go dependency to v0.46.0 & #741 Update the go version to 1.21.4 #743

Closed kmala closed 11 months ago

kmala commented 11 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

cherry pick of #741 and #740 on release-1.26

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- Updated GO version to  1.21.4 to fix CVE-2023-45283 
- Updated otel go dependency to fix CVE-2023-47108
k8s-ci-robot commented 11 months ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 11 months ago

Hi @kmala. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
torredil commented 11 months ago

/ok-to-test

dims commented 11 months ago

/approve /lgtm

cartermckinnon commented 11 months ago

/approve

k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cartermckinnon, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/release-1.26/OWNERS)~~ [cartermckinnon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mmerkes commented 11 months ago

@kmala You willing to backport this to 1.25-1.23 as well? Those release branches are still maintained.

kmala commented 11 months ago

@kmala You willing to backport this to 1.25-1.23 as well? Those release branches are still maintained.

I didn't backport as updating otel dependencies has backward incompatible changes which needs changes in the kubernetes/kubernetes where these branches are not maintained