search

kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
395 stars 302 forks source link

Cherrypick 1.25: Drop Node events when EC2 instance does not exist and node is not new #758

Closed mmerkes closed 10 months ago

mmerkes commented 11 months ago

What type of PR is this? /kind bug

What this PR does / why we need it: See https://github.com/kubernetes/cloud-provider-aws/pull/753 Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
k8s-ci-robot commented 11 months ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cartermckinnon commented 11 months ago

/lgtm /approve

cartermckinnon commented 11 months ago

/approve cancel

need to get the vulns patched on this branch

k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from cartermckinnon. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/release-1.25/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cartermckinnon commented 10 months ago

Dependency updates have been addressed on this branch in other PR's. @mmerkes is out of the office for a bit, and we need to get this fix in for a batch of releases soon. CI is green on the jobs that matter.