Closed haoranleo closed 10 months ago
Welcome @haoranleo!
It looks like this is your first PR to kubernetes/cloud-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/cloud-provider-aws has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
This issue is currently awaiting triage.
If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted
label and provide further guidance.
The triage/accepted
label can be added by org members by writing /triage accepted
in a comment.
Hi @haoranleo. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/assign cartermckinnon
/hold
Discussed offline, we'll wait until the 0.29.0
tags land upstream to avoid extra cycles.
/retitle Bump k8s.io dependencies to v0.29.0
/ok-to-test
/retest
Ran these checks locally and succeeded..
The CI is broken, folks are working on it 👍
/retest
/retest
/retest
/retest
/retest
/test pull-cloud-provider-aws-e2e-kubetest2-quick
/retest
/test pull-cloud-provider-aws-e2e-kubetest2
/retest
/retest
/hold remove /lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cartermckinnon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold cancel
What type of PR is this?
What this PR does / why we need it: Bump k8s.io depedencies to v1.29.0, and golang version to 1.21 to start releasing 1.29. We can create 1.29 release branch starting from this commit.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: