Closed kon-angelo closed 4 months ago
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
This issue is currently awaiting triage.
If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted
label and provide further guidance.
The triage/accepted
label can be added by org members by writing /triage accepted
in a comment.
Hi @kon-angelo. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign cartermckinnon for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/hold
While we explore other options. I don't think this is totally unreasonable, but I don't think it'll be used very often; and it has the downsides of increased image size and surface area for security scanners.
While we explore other options. I don't think this is totally unreasonable, but I don't think it'll be used very often; and it has the downsides of increased image size and surface area for security scanners.
@cartermckinnon I suggest creating a separate image for it, in case this is something needed in the future. I don't see any value in bundling it in a single image.
I suggest creating a separate image for it, in case this is something needed in the future. I don't see any value in bundling it in a single image.
Agreed; I don't think we're going to go this route. A container image just isn't the right way to distribute this.
/close
@cartermckinnon: Closed this PR.
What type of PR is this? /kind feature
What this PR does / why we need it: Adds ecr-credential-provider to the aws-cloud-controller-manager image.
Which issue(s) this PR fixes:
Fixes https://github.com/kubernetes/cloud-provider-aws/issues/823
Special notes for your reviewer:
Does this PR introduce a user-facing change?: