search

kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
375 stars 299 forks source link

AWS CCM DockerFile build for more than one platform #839

Open mixeract opened 5 months ago

mixeract commented 5 months ago

What would you like to be added: The current Dockerfile for Cloud Provider AWS is primarily configured for the amd64 architecture. As the usage of different architectures (like ARM) is becoming more prevalent, especially in cloud-native environments, it would be beneficial for this project to support multi-platform Docker builds.

DockerFile reference https://github.com/kubernetes/cloud-provider-aws/blob/master/Dockerfile#L32

Why is this needed: Supports users on different architectures, particularly important for ARM-based systems like AWS Graviton instance types.

/kind feature

k8s-ci-robot commented 5 months ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cartermckinnon commented 5 months ago

The Dockerfile is already set up to target whatever --platform you pass to buildx; I don't know why the platform of the golang image for the builder stage is hard-coded here. Removing it seems to work fine. @hakman did this have something to do with reproduceable builds?

hakman commented 5 months ago

@cartermckinnon I think so, probably can be removed now. ko builds could also be used. Probably we should drop the Dockerfile in the future.

cartermckinnon commented 5 months ago

thanks! If you want to put up a PR to remove this line @mixeract, feel free 👍

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

et304383 commented 1 month ago

@cartermckinnon @hakman opened #951

olemarkus commented 4 weeks ago

As mentioned in the PR, arm64 is already supported and published together with the amd64 images.

et304383 commented 4 weeks ago

As mentioned in the PR, arm64 is already supported and published together with the amd64 images.

My mistake. So is this issue already resolved? Should it be closed?