Closed mmerkes closed 4 months ago
This issue is currently awaiting triage.
If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted
label and provide further guidance.
The triage/accepted
label can be added by org members by writing /triage accepted
in a comment.
/assign @cartermckinnon @dims
/retest
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dims, olemarkus
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
What type of PR is this?
/kind cleanup /kind feature
What this PR does / why we need it:
The InstancesV2 interface is the path forward for cloud providers. To enable new changes, like providing custom labels, we need to migrate to InstancesV2 as they won't be implemented in the original Instances interface.
This change is needed to prepare to support #300
Which issue(s) this PR fixes: N/A
Special notes for your reviewer:
I've added unit tests here and the automation should run. I'll do some manual testing with an EKS cluster, but if you have suggestions on things I should test specifically, let me know.
Does this PR introduce a user-facing change?: