kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
376 stars 300 forks source link

Implements InstancesV2 interface #845

Closed mmerkes closed 4 months ago

mmerkes commented 5 months ago

What type of PR is this?

/kind cleanup /kind feature

What this PR does / why we need it:

The InstancesV2 interface is the path forward for cloud providers. To enable new changes, like providing custom labels, we need to migrate to InstancesV2 as they won't be implemented in the original Instances interface.

This change is needed to prepare to support #300

Which issue(s) this PR fixes: N/A

Special notes for your reviewer:

I've added unit tests here and the automation should run. I'll do some manual testing with an EKS cluster, but if you have suggestions on things I should test specifically, let me know.

Does this PR introduce a user-facing change?:

Migrate to InstancesV2 interface
k8s-ci-robot commented 5 months ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mmerkes commented 5 months ago

/assign @cartermckinnon @dims

mmerkes commented 4 months ago

/retest

dims commented 4 months ago

/approve

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/master/OWNERS)~~ [dims,olemarkus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
olemarkus commented 4 months ago

/lgtm