kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
388 stars 301 forks source link

Add zone-id topology label to nodes #855

Closed mmerkes closed 7 months ago

mmerkes commented 7 months ago

What type of PR is this? /kind feature

What this PR does / why we need it: As part of 1.30, we added the ability to add custom labels from the cloud provider to nodes, and AWS customers are looking for a way to label nodes with a zone ID, which will be consistent across account. That label is added here.\

Which issue(s) this PR fixes:

Fixes #300

Special notes for your reviewer: Added a new e2e case for this change.

Does this PR introduce a user-facing change?:

Label nodes with zone-id topology label. AWS customers can use the `topology.k8s.aws/zone-id`
label on their nodes to associate observations across AWS accounts in a consistent way.
mmerkes commented 7 months ago

/triage accepted /assign @cartermckinnon

olemarkus commented 7 months ago

Generally lgtm, but may want to split the deps upgrade as a separate PR. At least clean up/fixup the "merge" commit.

mmerkes commented 7 months ago

Generally lgtm, but may want to split the deps upgrade as a separate PR.

@olemarkus That's fair. I put up another PR to separate it out. I can remove the changes here once that's merged.

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cartermckinnon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/master/OWNERS)~~ [cartermckinnon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
olemarkus commented 7 months ago

Remember to change the PR description.

cartermckinnon commented 7 months ago

/retest

cartermckinnon commented 7 months ago

/lgtm