Closed mmerkes closed 7 months ago
/triage accepted /assign @cartermckinnon
Generally lgtm, but may want to split the deps upgrade as a separate PR. At least clean up/fixup the "merge" commit.
Generally lgtm, but may want to split the deps upgrade as a separate PR.
@olemarkus That's fair. I put up another PR to separate it out. I can remove the changes here once that's merged.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cartermckinnon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Remember to change the PR description.
/retest
/lgtm
What type of PR is this? /kind feature
What this PR does / why we need it: As part of 1.30, we added the ability to add custom labels from the cloud provider to nodes, and AWS customers are looking for a way to label nodes with a zone ID, which will be consistent across account. That label is added here.\
Which issue(s) this PR fixes:
Fixes #300
Special notes for your reviewer: Added a new e2e case for this change.
Does this PR introduce a user-facing change?: