kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
388 stars 301 forks source link

(cleanup): remove unused volume handling #898

Closed cartermckinnon closed 5 months ago

cartermckinnon commented 5 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This removes dead code associated with EBS volumes. This is old code from the legacy in-tree AWS provider, and has never been used in the AWS CCM. I sanity checked that it is not being used by the EBS or EFS CSI driver projects, and I don't see any usage searching around on grep.app.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Legacy volume handling has been removed.
k8s-ci-robot commented 5 months ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cartermckinnon commented 5 months ago

/assign @mmerkes

mmerkes commented 5 months ago

/lgtm /approve

Tx for cleaning this up! Can believe we had so much dead code in here.

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmerkes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/master/OWNERS)~~ [mmerkes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment