search

kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
374 stars 299 forks source link

updating deps to v1.30.0 #899

Closed jaidevmane closed 2 months ago

jaidevmane commented 2 months ago

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it: Bump k8s lib to V0.30.0 to cut new 1.30 CCM release for 1.30 launch.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
k8s-ci-robot commented 2 months ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 2 months ago

Hi @jaidevmane. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cartermckinnon commented 2 months ago

/ok-to-test

cartermckinnon commented 2 months ago

/lgtm /approve

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cartermckinnon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/release-1.30/OWNERS)~~ [cartermckinnon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cartermckinnon commented 2 months ago

@jaidevmane can you bump the go version as well, to resolve the vulncheck failures?

jaidevmane commented 2 months ago

/retest

cartermckinnon commented 2 months ago

@jaidevmane you'll have to update the other references to the go version, example here: https://github.com/kubernetes/cloud-provider-aws/pull/764

jaidevmane commented 2 months ago

Thanks @cartermckinnon. I will add an update.

cartermckinnon commented 2 months ago

/lgtm

cartermckinnon commented 2 months ago

Thanks @jaidevmane! Can you open a PR to bump go on master while you're at it? 😉

jaidevmane commented 2 months ago

Yes. Will gladly do so!

jaidevmane commented 2 months ago

PR to update go version in master branch https://github.com/kubernetes/cloud-provider-aws/pull/900