Closed github-actions[bot] closed 1 month ago
Hi @github-actions[bot]. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
This issue is currently awaiting triage.
If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted
label and provide further guidance.
The triage/accepted
label can be added by org members by writing /triage accepted
in a comment.
/retest
@hakman the CI is broken:
error fetching s3://cloud-provider-aws-shared-e2e/test-cluster-20240516033144.k8s/config: operation error S3: GetObject, get identity: get credentials: failed to refresh cached credentials, failed to retrieve credentials, operation error STS: AssumeRoleWithWebIdentity, https response error StatusCode: 0, RequestID: , request send failed, Post "https://sts.us-east-1.api.aws/": dial tcp: lookup sts.us-east-1.api.aws on 172.20.0.10:53: no such host
I think the issue is this: https://github.com/kubernetes/kops/blob/937663a62445cc395551f3403e67ab76597d49bd/util/pkg/vfs/s3context.go#L90
DualStackEndpointStateEnabled
is causing a non-existant STS endpoint to be used by the credential provider.
Thanks @cartermckinnon! @rifelpet @ameukam any thoughts, not exactly sure why this happens only at the end of the test, during cluster deletion.
No idea. I suspect the upgrade of the AWS SDK.
Agree, this ultimately looks like an SDK bug, don't see a reasonable workaround. Let me bug them....
FYI @dims @hakuna-matatah ^^^
/test pull-cloud-provider-aws-e2e
Attempting to fix the dual-stack issue via https://github.com/kubernetes/kops/pull/16575. Looks like it worked, but would appreciate a double check.
thank you @hakman!
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cartermckinnon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Updating go.mod with latest dependencies.