kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
374 stars 299 forks source link

Update dependencies #914

Closed github-actions[bot] closed 1 month ago

github-actions[bot] commented 1 month ago

Updating go.mod with latest dependencies.

k8s-ci-robot commented 1 month ago

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 month ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
hakman commented 1 month ago

/retest

cartermckinnon commented 1 month ago

@hakman the CI is broken:

error fetching s3://cloud-provider-aws-shared-e2e/test-cluster-20240516033144.k8s/config: operation error S3: GetObject, get identity: get credentials: failed to refresh cached credentials, failed to retrieve credentials, operation error STS: AssumeRoleWithWebIdentity, https response error StatusCode: 0, RequestID: , request send failed, Post "https://sts.us-east-1.api.aws/": dial tcp: lookup sts.us-east-1.api.aws on 172.20.0.10:53: no such host

I think the issue is this: https://github.com/kubernetes/kops/blob/937663a62445cc395551f3403e67ab76597d49bd/util/pkg/vfs/s3context.go#L90

DualStackEndpointStateEnabled is causing a non-existant STS endpoint to be used by the credential provider.

hakman commented 1 month ago

Thanks @cartermckinnon! @rifelpet @ameukam any thoughts, not exactly sure why this happens only at the end of the test, during cluster deletion.

ameukam commented 1 month ago

No idea. I suspect the upgrade of the AWS SDK.

cartermckinnon commented 1 month ago

Agree, this ultimately looks like an SDK bug, don't see a reasonable workaround. Let me bug them....

hakman commented 1 month ago

FYI @dims @hakuna-matatah ^^^

hakman commented 1 month ago

/test pull-cloud-provider-aws-e2e

hakman commented 1 month ago

Attempting to fix the dual-stack issue via https://github.com/kubernetes/kops/pull/16575. Looks like it worked, but would appreciate a double check.

cartermckinnon commented 1 month ago

thank you @hakman!

cartermckinnon commented 1 month ago

/lgtm /approve

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cartermckinnon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/master/OWNERS)~~ [cartermckinnon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment