search

kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
374 stars 299 forks source link

Allows user to specify imagepullsecret #952

Closed apt-x4869 closed 3 weeks ago

apt-x4869 commented 3 weeks ago

What type of PR is this?

/kind feature

What this PR does / why we need it: Requirement is to specify credentials for pulling image from private registry.

Which issue(s) this PR fixes: Allows user to specify imagepullsecret Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?: NONE

release-note:

Allows user to specify imagepullsecret
linux-foundation-easycla[bot] commented 3 weeks ago

CLA Missing ID CLA Not Signed

k8s-ci-robot commented 3 weeks ago

Welcome @apt-x4869!

It looks like this is your first PR to kubernetes/cloud-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 3 weeks ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 weeks ago

Hi @apt-x4869. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kmala commented 3 weeks ago

the helm charts are planned to be deleted and is discussed here https://github.com/kubernetes/cloud-provider-aws/issues/933

cartermckinnon commented 3 weeks ago

/hold

@apt-x4869 you'll need to sign the CLA before we can proceed.

apt-x4869 commented 3 weeks ago

/hold

@apt-x4869 you'll need to sign the CLA before we can proceed.

Signed

apt-x4869 commented 3 weeks ago

/retest

k8s-ci-robot commented 3 weeks ago

@apt-x4869: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/kubernetes/cloud-provider-aws/pull/952#issuecomment-2164127022): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
apt-x4869 commented 3 weeks ago

/check-cla

apt-x4869 commented 3 weeks ago

/check-cla

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment