search

kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
374 stars 299 forks source link

Allow user to specify Registry Pull Secret #954

Open apt-x4869 opened 3 weeks ago

apt-x4869 commented 3 weeks ago

What type of PR is this? /kind feature

What this PR does / why we need it: Requirement is to specify credentials for pulling image from private registry.

Which issue(s) this PR fixes: Allows user to specify imagepullsecret Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?: NONE

release-note:

Allow user to specify imagePullSecrets
k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kishorj for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 3 weeks ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 weeks ago

Hi @apt-x4869. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
apt-x4869 commented 2 weeks ago

/kind feature

apt-x4869 commented 2 weeks ago

@cartermckinnon @dims , Could you review ?

dims commented 2 weeks ago

@apt-x4869 dunno which way we will go https://github.com/kubernetes/cloud-provider-aws/issues/933

Do you mind adding what your use case is in that issue?

apt-x4869 commented 1 week ago

@apt-x4869 dunno which way we will go #933

Do you mind adding what your use case is in that issue?

@dims Added use case.