kubernetes / cloud-provider-aws

Cloud provider for AWS
https://cloud-provider-aws.sigs.k8s.io/
Apache License 2.0
374 stars 299 forks source link

format the instance metadata details log #992

Closed kmala closed 3 days ago

kmala commented 3 days ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Formats the instance metadata log message properly such that its easier to look for the details. Before : instance metadata identityregionus-west-2availability-zoneus-west-2ainstance-typem5.largearchitecturex86_64instance-idi-0b0e5f62cc663a8b9private-ip172.16.59.42account-idxxxximage-idami-089dfc7e6aaa02c83 After : instance metadata identity" region="us-west-2" availability-zone="us-west-2a" instance-type="m5.large" architecture="x86_64" instance-id="i-0b0e5f62cc663a8b9" private-ip="172.16.59.42" account-id="xxx" image-id="ami-089dfc7e6aaa02c83

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
k8s-ci-robot commented 3 days ago

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dims commented 3 days ago

/approve /lgtm

thanks @kmala

k8s-ci-robot commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-aws/blob/master/OWNERS)~~ [dims] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment