search

kubernetes / cloud-provider-gcp

cloud-provider-gcp contains several projects used to run Kubernetes in Google Cloud
Apache License 2.0
118 stars 208 forks source link

*v1alpha1.GKENetworkParamSet is spamming the logs if the CRD is not installed #459

Closed aojea closed 1 year ago

aojea commented 1 year ago

I0207 19:47:47.178909 11 reflector.go:257] Listing and watching v1alpha1.GKENetworkParamSet from cmd/cloud-controller-manager/gkenetworkparamsetcontroller.go:53 W0207 19:47:47.180949 11 reflector.go:424] cmd/cloud-controller-manager/gkenetworkparamsetcontroller.go:53: failed to list v1alpha1.GKENetworkParamSet: the server could not find the requested resource (get gkenetworkparamsets.networking.gke.io) E0207 19:47:47.181025 11 reflector.go:140] cmd/cloud-controller-manager/gkenetworkparamsetcontroller.go:53: Failed to watch v1alpha1.GKENetworkParamSet: failed to list v1alpha1.GKENetworkParamSet: the server could not find the requested resource (get gkenetworkparamsets.networking.gke.io)

see in the logfile

https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/cloud-provider-gcp/452/cloud-provider-gcp-e2e-full/1623042678595784704/artifacts/cluster-logs/kt2-84e756a9-a71e-master/cloud-controller-manager.log

maybe it should have a flag to enable it?

@jprzychodzen @shouri007

jprzychodzen commented 1 year ago

Yeah, I found out that this new controller is enabled in our E2E tests. It's already behind the flag, correlated with but we are not setting it.

Actually, it's worse, as the env RUN_CONTROLLERS is broken (it's also used by KCM), so we need to fix also that. In upstream K/K, as here we are mirroring /cluster from K/K.

jprzychodzen commented 1 year ago

We need to productionise part of https://github.com/kubernetes/cloud-provider-gcp/pull/458 related to controllers

jprzychodzen commented 1 year ago

K/K's PR: https://github.com/kubernetes/kubernetes/pull/115619

aojea commented 1 year ago

do we need to fix it in k/k?

jprzychodzen commented 1 year ago

We need to, right now we have a broken situation when we can't set different controllers between KCM and CCM.

Temporarily we can have an in-repo patch, but let's not plan to have this situation permanently.