search

kubernetes / cloud-provider-openstack

Apache License 2.0
619 stars 610 forks source link

[OCCM] occm version not displayed correctly since 1.21 release #1502

Closed ramineni closed 2 years ago

ramineni commented 3 years ago

Is this a BUG REPORT or FEATURE REQUEST?: occm version not displayed correctly on using refactored cloudprovider code from k/k 1.21 release

Uncomment only one, leave it on its own line:

/kind bug /kind feature

What happened:

What you expected to happen:

How to reproduce it:

Anything else we need to know?:

Environment:

lingxiankong commented 3 years ago

ref: https://github.com/kubernetes/cloud-provider-openstack/pull/1440#discussion_r620822121

jichenjc commented 3 years ago

/kind bug

jichenjc commented 3 years ago

@ramineni can you link the bug you mentioned in #1440 to cloud-provider repo when it's ready?so we know whether some way proposed there instead fix by using our own version number.. thanks

ialidzhikov commented 3 years ago

/triage accepted

k8s-ci-robot commented 3 years ago

@ialidzhikov: The label triage/accepted cannot be applied. Only GitHub organization members can add the label.

In response to [this](https://github.com/kubernetes/cloud-provider-openstack/issues/1502#issuecomment-844117187): >/triage accepted Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ramineni commented 3 years ago

/assign

ramineni commented 3 years ago

raised issue in cloudprovider repo for the same , https://github.com/kubernetes/cloud-provider/issues/49

k8s-triage-robot commented 3 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ialidzhikov commented 3 years ago

/remove-lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ramineni commented 2 years ago

/remove-lifecycle stale

MPV commented 2 years ago

Would it be worth peeking at how they did it for the AWS provider — would it work for us here too?

https://github.com/kubernetes/cloud-provider-aws/pull/317

jichenjc commented 2 years ago

looks like the problem can be solved by using there example

the only question I am having is following 


# ./openstack-cloud-controller-manager-amd64 --version
Kubernetes v1.17.0-426-g033052e-dirty

on master branch
#  git describe
v1.17.0-427-g11155c9

# git checkout v1.23.1
Note: checking out 'v1.23.1'.

# git describe
v1.23.0-4-g1b5899e

so git describe looks like search for latest tag it can reach at the current branch, we are using 1.17 now so I guess everytime we do a release is create a release branch then tag on that branch thus master branch can only reach 1.17 ? if we accept this, then I can submit a PR for this @ramineni @lingxiankong @MPV

lingxiankong commented 2 years ago

so I guess everytime we do a release is create a release branch then tag on that branch

Yeah, we should change this.

I think this method could be good workaround for now.