[OCCM]use prometheus metrics to replace legacy one?

[jichenjc]

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug /kind feature

What happened: https://github.com/kubernetes/cloud-provider-openstack/blob/master/pkg/metrics/metrics_reconcile.go#L23 is using legacy metrics, can we move to prometheus (more up-to-date)

What you expected to happen:

How to reproduce it:

Anything else we need to know?:

Environment:

• openstack-cloud-controller-manager(or other related binary) version:
• OpenStack version:
• Others:

[jichenjc]

@seanschneeweiss can you help to provide some comments?

[seanschneeweiss]

I think that most metrics were migrated to legacyregistry as part of the KEP-1209: Metrics Stability Framework.

As far as I understand it, we are already using Prometheus wrapped behind the k8s.io/component-base/metrics package. Most other cloud providers are also creating metrics similar to us. E.g. this PR moves from Prometheus to k8s.io/component-base/metrics.

Not sure if we should move "back".

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[ramineni]

/remove-lifecycle stale

[ramineni]

@jichenjc Can we close this?

[jichenjc]

ok, let's close this