search

kubernetes / cloud-provider-openstack

Apache License 2.0
616 stars 603 forks source link

Release v1.26.0 have docker tag "latest" in manifest files #2085

Closed huxcrux closed 8 months ago

huxcrux commented 1 year ago

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened: The latest release v1.26.0 have docker tag "latest" in manifest files. I first noticed this in the "manifests/controller-manager/openstack-cloud-controller-manager-ds.yaml" file however this issue seems to also affect other manifests.

What you expected to happen: I expected the release manifests to have tagged versions of all docker containers

How to reproduce it: N/A

Anything else we need to know?:

Environment:

zetaab commented 1 year ago

https://github.com/kubernetes/cloud-provider-openstack/blob/release-1.26/manifests/controller-manager/openstack-cloud-controller-manager-ds.yaml#L41 I do not see what is the issue here?

huxcrux commented 1 year ago

It looks like the Github Release points towards the v1.26.0 tag in this tag all docker image tags are set to "latest": https://github.com/kubernetes/cloud-provider-openstack/blob/v1.26.0/manifests/controller-manager/openstack-cloud-controller-manager-ds.yaml#L41

It looks like the release-1.26 branch is correct, maybe the release/tag was created from the wrong branch?

Jonher937 commented 1 year ago

Had the same issue today where I installed cinder-csi from v1.26.0 tag and got an older cinder-csi-plugin version than I was running previously. Indeed the release branch looks OK as @bl0m1 mentioned and @zetaab confirmed.

The commit the GitHub release v1.26.0 was created from is before the two latest commits from @zetaab on the release branch.

zetaab commented 1 year ago

please check the latest versions is this solved?

huxcrux commented 1 year ago

please check the latest versions is this solved?

I can confirm this is fixed in tag "v1.26.1" :)

Jonher937 commented 1 year ago

v1.26.1 looks good.

Why I noticed the same problem as bl0m1 is because the :latest tag seems multiple months old. I tried looking in docker.io/k8scloudprovider/cinder-csi-plugin:latest starting /bin/cinder-csi-plugin --version but there was no version flag. However stat shows this:

# stat /bin/cinder-csi-plugin
  File: /bin/cinder-csi-plugin
  Size: 31727616    Blocks: 61968      IO Block: 4096   regular file
Device: 42h/66d Inode: 6432784     Links: 1
Access: (0755/-rwxr-xr-x)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2022-05-20 11:27:10.000000000 +0000
Modify: 2022-05-20 11:27:10.000000000 +0000

And:

docker image inspect 0e5eab390de4 | grep Created
        "Created": "2022-05-20T11:27:33.211099275Z",

So if :latest is used in development branches it needs to be updated. I don't know if this is true for and of the other images.

zetaab commented 1 year ago

our ci pipelines are not updating latest tag currently at all

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 8 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/cloud-provider-openstack/issues/2085#issuecomment-1899406510): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dulek commented 8 months ago 
mdulko:~/ $ podman pull registry.k8s.io/kubernetes/kube-apiserver:latest 
Trying to pull registry.k8s.io/kubernetes/kube-apiserver:latest...
Error: initializing source docker://registry.k8s.io/kubernetes/kube-apiserver:latest: reading manifest latest in registry.k8s.io/kubernetes/kube-apiserver: manifest unknown: Failed to fetch "latest"

I think this is a convention here, KAS doesn't have :latest as well.