search

kubernetes / cloud-provider-openstack

Apache License 2.0
613 stars 599 forks source link

[manila-csi-plugin]: use new access rules GET method when possible #2277

Open kayrus opened 1 year ago

kayrus commented 1 year ago

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

What happened:

Some OpenStack deployments can have middlewares that limit an amount of POST/PUT requests, which are categorized as write requests. One of the wrongly categorized request is a deprecated list access rules action.

What you expected to happen:

In order to prevent excessive requests rate limiting, CSI Manila plugin should support a newer Manila API call.

How to reproduce it:

n/a

Anything else we need to know?:

See also https://github.com/terraform-provider-openstack/terraform-provider-openstack/issues/1582

Environment:

cc @Carthaca

mdbooth commented 1 year ago

According to https://docs.openstack.org/manila/latest/contributor/api_microversion_history.html#id40 it looks like this microversion has been available since Rocky which, according to https://releases.openstack.org/ is the oldest release which isn't EOL.

That said, if we bumped the minimum microversion to Rocky it still might make folks like @lentzi90 unhappy. We should discuss which versions of OpenStack we want to support.

kayrus commented 1 year ago

@mdbooth see a PR that corresponds to https://github.com/terraform-provider-openstack/terraform-provider-openstack/issues/1582. Before calling the share access list, we check API microversions.

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

gouthampacha commented 7 months ago

/remove-lifecycle stale

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

gouthampacha commented 4 months ago

/remove-lifecycle stale

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

kayrus commented 1 month ago

/remove-lifecycle stale