kubernetes / cloud-provider-openstack

Apache License 2.0
615 stars 603 forks source link

[all]: openstack API debugger shows `client.go:128` for all calls #2300

Open kayrus opened 1 year ago

kayrus commented 1 year ago

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:

I noticed that all API debug logs have client.go:128 prefix from the https://github.com/kubernetes/cloud-provider-openstack/issues/2295#issuecomment-1634366621 logs

What you expected to happen:

Logs should show the actual place of the call, e.g. in 1.25 it is:

I0713 11:50:50.686815       1 openstack_volumes.go:82]   "volumes_links": [
I0713 11:50:50.686831       1 openstack_volumes.go:82]     {
I0713 11:50:50.686845       1 openstack_volumes.go:82]       "href": "https://cinder-v3/v3/4d0477a019414ee08ad0fd11b777eee2/volumes/detail?limit=2\u0026marker=faf60902-227c-4812-ac35-fb5f1aea7e7f",
I0713 11:50:50.686863       1 openstack_volumes.go:82]       "rel": "next"
I0713 11:50:50.686877       1 openstack_volumes.go:82]     }
I0713 11:50:50.686892       1 openstack_volumes.go:82]   ]
I0713 11:50:50.686909       1 openstack_volumes.go:82] }

How to reproduce it:

n/a

Anything else we need to know?:

https://github.com/kubernetes/cloud-provider-openstack/pull/867

Environment:

jichenjc commented 1 year ago

good catch~

you mean #867 might be the root cause or it's reference that previously it works fine?

kayrus commented 1 year ago

@jichenjc it's a reference for the initial implementation. I don't know at what point it stopped to work, but for sure it works fine in 1.25.x

majorchork commented 11 months ago

/assign